Source/modules/serviceworkers/ServiceWorkerClients.h - Issue 892053003: Rename ServiceWorkerClients.getAll to matchAll in M42

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/ServiceWorkerClients.h

Issue 892053003: Rename ServiceWorkerClients.getAll to matchAll in M42 (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/frame/UseCounter.cpp ('K') | « Source/modules/serviceworkers/Clients.idl ('k') | Source/modules/serviceworkers/ServiceWorkerClients.cpp » ('j') | Source/modules/serviceworkers/ServiceWorkerClients.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/serviceworkers/ServiceWorkerClients.h

diff --git a/Source/modules/serviceworkers/ServiceWorkerClients.h b/Source/modules/serviceworkers/ServiceWorkerClients.h

index a6b6f4d6cb23cb0b04594fe18ce5d6c073c5121d..d9cd4cd1f62b13227f85ad67a775c8fab589600d 100644

--- a/Source/modules/serviceworkers/ServiceWorkerClients.h

+++ b/Source/modules/serviceworkers/ServiceWorkerClients.h

@@ -21,7 +21,10 @@ public:

static ServiceWorkerClients* create();

// Clients.idl

+ // DEPRECATED, please use matchAll instead

falken 2015/02/13 10:16:00 nit: add a period to end of the comment. Also, add

zhuoyu.qian 2015/02/13 10:47:05 Done.

ScriptPromise getAll(ScriptState*, const ClientQueryOptions&);

+ ScriptPromise matchAll(ScriptState*, const ClientQueryOptions&);

ScriptPromise openWindow(ScriptState*, const String& url);

ScriptPromise claim(ScriptState*);