Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 892053002: Cleanup unused #includes and declarations in PlatformImpl (Closed)

Created:
5 years, 10 months ago by abarth-chromium
Modified:
5 years, 10 months ago
Reviewers:
eseidel, ojan
CC:
eseidel, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Cleanup unused #includes and declarations in PlatformImpl These aren't needed anymore. Also, use more |override|. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/3714dbabb5e7a5a1a7446c7a7dd068dd7bb0b7ab

Patch Set 1 #

Patch Set 2 : Leave locale #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -53 lines) Patch
M sky/engine/public/platform/Platform.h View 1 1 chunk +0 lines, -14 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.h View 1 2 chunks +4 lines, -8 lines 0 comments Download
M sky/engine/testing/platform/platform_impl.cc View 1 1 chunk +0 lines, -10 lines 0 comments Download
M sky/viewer/platform/platform_impl.h View 1 2 chunks +6 lines, -10 lines 0 comments Download
M sky/viewer/platform/platform_impl.cc View 1 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
abarth-chromium
5 years, 10 months ago (2015-02-01 17:45:18 UTC) #1
eseidel
So the purpose of this is for portability. So that you can easily wire it ...
5 years, 10 months ago (2015-02-01 18:32:06 UTC) #3
eseidel
That can also be a later problem. If you're going to do this, add a ...
5 years, 10 months ago (2015-02-01 18:32:52 UTC) #4
eseidel
Does base have a locale system?
5 years, 10 months ago (2015-02-01 18:33:46 UTC) #5
abarth-chromium
Ok. Let's leave this. I'll post a new CL with just the cleanup part of ...
5 years, 10 months ago (2015-02-01 19:10:42 UTC) #6
abarth-chromium
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/chrome_browser_main.cc&sq=package:chromium&rcl=1422766869&l=890
5 years, 10 months ago (2015-02-01 19:11:37 UTC) #7
abarth-chromium
PTAL (just cleanup now)
5 years, 10 months ago (2015-02-01 19:14:55 UTC) #8
eseidel
lgtm Entertainingly platform/ used to be all non-virtual compile-time interfaces before Chromium came on the ...
5 years, 10 months ago (2015-02-01 20:49:43 UTC) #9
abarth-chromium
5 years, 10 months ago (2015-02-01 21:40:47 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3714dbabb5e7a5a1a7446c7a7dd068dd7bb0b7ab (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698