Issue 892043004: gn: Do not advertise a rebase_path() command with more than 3 parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 892043004: gn: Do not advertise a rebase_path() command with more than 3 parameters. (Closed)

Created:
5 years, 10 months ago by tfarina

Modified:
5 years, 10 months ago

Reviewers:
scottmg

CC:
chromium-reviews, tfarina, brettw, mdempsky

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

gn: Do not advertise a rebase_path() command with more than 3 parameters. Currently rebase_path() function takes up to three parameters, so passing a fourth won't work. This was probably due to the work done in: https://chromium.googlesource.com/chromium/src/+/ee55eaceea8d7632a59761c603af0f4503db00df BUG=434539 TEST=gn help rebase_path R=scottmg@chromium.org Committed: https://crrev.com/9c9a966eac639c6ed862485376012d453ade59fc Cr-Commit-Position: refs/heads/master@{#314097}

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -4 lines)			Patch
	M	tools/gn/function_rebase_path.cc	View		1 chunk	+0 lines, -4 lines	0 comments	Download

Total messages: 6 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/892043004/1

5 years, 10 months ago (2015-02-01 23:19:23 UTC) #4

commit-bot: I haz the power

5 years, 10 months ago (2015-02-01 23:23:51 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/9c9a966eac639c6ed862485376012d453ade59fc
Cr-Commit-Position: refs/heads/master@{#314097}