Issue 892033003: Consolidate and delete a bunch of paint methods.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 892033003: Consolidate and delete a bunch of paint methods. (Closed)

Created:
5 years, 10 months ago by ojan

Modified:
5 years, 10 months ago

Reviewers:
esprehn

CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Consolidate and delete a bunch of paint methods. We've simplified paint code enough that most of these methods are redundant. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/817735f64dab260dfc1bcb4ff1834fa3a75944e2

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -169 lines)			Patch
M	sky/engine/core/frame/FrameView.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	sky/engine/core/frame/FrameView.cpp	View	3 chunks	+2 lines, -7 lines	0 comments	Download
M	sky/engine/core/rendering/InlineBox.cpp	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlock.h	View	3 chunks	+0 lines, -9 lines	0 comments	Download
M	sky/engine/core/rendering/RenderBlock.cpp	View	2 chunks	+5 lines, -27 lines	0 comments	Download
M	sky/engine/core/rendering/RenderFlexibleBox.cpp	View	1 chunk	+4 lines, -2 lines	0 comments	Download
M	sky/engine/core/rendering/RenderParagraph.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/core/rendering/RenderParagraph.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	sky/engine/public/BUILD.gn	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	sky/engine/public/platform/WebContentLayer.h	View	1 chunk	+0 lines, -59 lines	0 comments	Download
D	sky/engine/public/platform/WebContentLayerClient.h	View	1 chunk	+0 lines, -58 lines	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 10 months ago (2015-02-02 05:01:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
817735f64dab260dfc1bcb4ff1834fa3a75944e2 (presubmit successful).