Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(5)

Issue 8920011: Merge 102602 - Source/WebCore: A SubresourceLoader in the middle of revalidating (Closed)

Created:
9 years, 2 months ago by Nate Chapin
Modified:
9 years, 2 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/963/
Visibility:
Public.

Description

Merge 102602 - Source/WebCore: A SubresourceLoader in the middle of revalidating a resource should be treated as finishing (similar to didFinishLoading and didFail) to ensure that willCancel() doesn't declare the revalidation as having failed reentrantly. https://bugs.webkit.org/show_bug.cgi?id=72762 Reviewed by Adam Barth. Test: http/tests/cache/cancel-during-revalidation-succeeded.html * loader/SubresourceLoader.cpp: (WebCore::SubresourceLoader::didReceiveResponse): LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=72762 Reviewed by Adam Barth. * http/tests/cache/cancel-during-revalidation-succeeded-expected.txt: Added. * http/tests/cache/cancel-during-revalidation-succeeded.html: Added. * http/tests/cache/resources/stylesheet304.php: Added. TBR=japhet@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=102614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, --1 lines) Patch
A + LayoutTests/http/tests/cache/cancel-during-revalidation-succeeded.html View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/cache/cancel-during-revalidation-succeeded-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + LayoutTests/http/tests/cache/resources/stylesheet304.php View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/WebCore/loader/SubresourceLoader.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/WebCore/loader/SubresourceLoader.cpp View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nate Chapin
9 years, 2 months ago (2011-12-12 21:26:03 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698