Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 891993003: Fix GN PDFium build when building all. (Closed)

Created:
5 years, 10 months ago by jam
Modified:
5 years, 10 months ago
Reviewers:
brettw
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix GN PDFium build when building all. The problem was FT_INTERNAL_DEBUG_H wasn't being defined because FT2_BUILD_LIBRARY wasn't set. So even if PDFium isn't using bundled FreeType, the FreeType target needs FT2_BUILD_LIBRARY defined. The GYP build was already correct. BUG=453844 TBR=brettw Committed: https://pdfium.googlesource.com/pdfium/+/b3a788e5e37955620b26be5b6e3048d37b605e00

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -4 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jam
5 years, 10 months ago (2015-02-02 00:19:20 UTC) #2
jam
5 years, 10 months ago (2015-02-02 00:19:33 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
b3a788e5e37955620b26be5b6e3048d37b605e00 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698