[Autofill] Take into account autocomplete prediction in Quality* metrics

[Autofill] Take into account autocomplete prediction in Quality* metrics

Per bug description, the "HtmlType" attribute wasn't carried over when processing a cached form for quality assessment.

BUG=454151
TEST=AutofillMetricsTest

Committed: https://crrev.com/188b6e0670208c803fcb67d01ad8751ee84ba483
Cr-Commit-Position: refs/heads/master@{#314316}

[Mathieu, 2015-02-01 06:10:46]

mathp@chromium.org changed reviewers:
+ isherman@chromium.org

[Mathieu, 2015-02-01 06:14:05]

On 2015/02/01 06:10:46, Mathieu Perreault wrote:
> mailto:mathp@chromium.org changed reviewers:
> + mailto:isherman@chromium.org

Hi Ilya, please have a look!

Note: I realize that autocomplete attributes are not really "Predicted" types,
and so perhaps the bug I am claiming to fix was intentionally coded like this so
that LogQualityMetrics would be in the dark wrt the autocomplete-derived type. 
However since we are using PredictedType as a metric for overall performance of
Autofill I think it's worthy to have it include "autocomplete" performance. Let
me know if you'd like to have this in a separate metric or amend the histogram
description.

[Ilya Sherman, 2015-02-02 22:28:12]

LGTM % comments.  Good catch!

https://codereview.chromium.org/891983002/diff/20001/components/autofill/core...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/891983002/diff/20001/components/autofill/core...
components/autofill/core/browser/autofill_metrics_unittest.cc:380:
field1.is_autofilled = false;
Isn't false the default value for is_autofilled?

https://codereview.chromium.org/891983002/diff/20001/components/autofill/core...
components/autofill/core/browser/autofill_metrics_unittest.cc:392:
test::CreateTestFormField("Phone", "phone", "2125551212", "tel", &field3);
nit: I'd recommend setting the starting values for all the fields to be empty
strings, as this is more representative of what happens in real-world forms
(with the exception of <select> fields, which are often pre-filled in the real
world).

[Mathieu, 2015-02-03 03:19:41]

The CQ bit was checked by mathp@chromium.org

[Mathieu, 2015-02-03 03:19:48]

Thanks, submitting!

https://codereview.chromium.org/891983002/diff/20001/components/autofill/core...
File components/autofill/core/browser/autofill_metrics_unittest.cc (right):

https://codereview.chromium.org/891983002/diff/20001/components/autofill/core...
components/autofill/core/browser/autofill_metrics_unittest.cc:380:
field1.is_autofilled = false;
On 2015/02/02 22:28:12, Ilya Sherman wrote:
> Isn't false the default value for is_autofilled?

Done.

https://codereview.chromium.org/891983002/diff/20001/components/autofill/core...
components/autofill/core/browser/autofill_metrics_unittest.cc:392:
test::CreateTestFormField("Phone", "phone", "2125551212", "tel", &field3);
On 2015/02/02 22:28:12, Ilya Sherman wrote:
> nit: I'd recommend setting the starting values for all the fields to be empty
> strings, as this is more representative of what happens in real-world forms
> (with the exception of <select> fields, which are often pre-filled in the real
> world).

Done.

[commit-bot: I haz the power, 2015-02-03 03:19:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891983002/40001

[commit-bot: I haz the power, 2015-02-03 05:21:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-02-03 05:21:17]

Try jobs failed on following builders:
  win8_chromium_rel on tryserver.chromium.win (None)

[Mathieu, 2015-02-03 12:21:39]

The CQ bit was checked by mathp@chromium.org

[commit-bot: I haz the power, 2015-02-03 12:22:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891983002/40001

[commit-bot: I haz the power, 2015-02-03 12:23:03]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-02-03 12:24:34]

Patchset 3 (id:??) landed as
https://crrev.com/188b6e0670208c803fcb67d01ad8751ee84ba483
Cr-Commit-Position: refs/heads/master@{#314316}