Issue 891953002: Fix subzero Windows build

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 891953002: Fix subzero Windows build (Closed)

Created:
5 years, 10 months ago by JF

Modified:
5 years, 10 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix subzero Windows build MinGW's GCC 4.8.1 was sad because SectionType was shadowing the other SectionType. Also, the enum's values are in the ELFObjectWriter namespace, not ELFObjectWriter::SectionType. R=stichnot@chromium.org, jvoung@chromium.org BUG= Windows build is sad Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=ae6e12ca4612ba33cd8dbc33233a7ee97a0122c3

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -11 lines)			Patch
	M	src/IceELFObjectWriter.cpp	View		7 chunks	+10 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

5 years, 10 months ago (2015-01-31 18:13:30 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
ae6e12ca4612ba33cd8dbc33233a7ee97a0122c3 (presubmit successful).