ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc - Issue 8919014: Revert "Revert 113479 - Revert "Revert 113250 - Add CommandBuffer::SetGetBuffer""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc

Issue 8919014: Revert "Revert 113479 - Revert "Revert 113250 - Add CommandBuffer::SetGetBuffer"" (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 9 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ppapi/native_client/src/shared/ppapi_proxy/command_buffer_nacl.cc ('k') | ppapi/native_client/src/shared/ppapi_proxy/ppb_graphics_3d.srpc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc

diff --git a/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc b/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc

index 6d06126b1f19c0ee4b20984b9a69fa3ef158cf1a..e00e9f9239f2207c16e65b76991d66a4cd440122 100644

--- a/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc

+++ b/ppapi/native_client/src/shared/ppapi_proxy/plugin_ppb_graphics_3d.cc

@@ -211,12 +211,9 @@ bool PluginGraphics3D::InitFromBrowserResource(PP_Resource res) {

// Create and initialize the objects required to issue GLES2 calls.

command_buffer_.reset(new CommandBufferNacl(res, PluginCore::GetInterface()));

- if (command_buffer_->Initialize(kRingBufferSize)) {

+ if (command_buffer_->Initialize()) {

gles2_helper_.reset(new gpu::gles2::GLES2CmdHelper(command_buffer_.get()));

- gpu::Buffer buffer = command_buffer_->GetRingBuffer();

- DebugPrintf("PluginGraphics3D::InitFromBrowserResource: buffer size: %d\n",

- buffer.size);

- if (gles2_helper_->Initialize(buffer.size)) {

+ if (gles2_helper_->Initialize(kRingBufferSize)) {

// Request id -1 to signify 'don't care'

int32 transfer_buffer_id =

command_buffer_->CreateTransferBuffer(kTransferBufferSize, -1);