Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Issue 891883002: Cleanup: Remove an unused variable in chrome_browser_main.cc. (Closed)

Created:
5 years, 10 months ago by Lei Zhang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Remove an unused variable in chrome_browser_main.cc. Also remove references to deleted BrowserMainTest. BUG=139429 Committed: https://crrev.com/4adea21c6771ac1aaa6260524c3c283e85415672 Cr-Commit-Position: refs/heads/master@{#314366}

Patch Set 1 #

Patch Set 2 : Moar #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -15 lines) Patch
M build/android/pylib/gtest/filter/unit_tests_disabled View 1 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/chrome_browser_main.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Lei Zhang
This was added in r134524, but the test was removed in r191507.
5 years, 10 months ago (2015-01-31 04:25:12 UTC) #2
Lei Zhang
+sashab, Just looking for someone who is around to stamp this.
5 years, 10 months ago (2015-02-03 03:04:02 UTC) #4
sashab
You picked the week I was in london ;) lgtm.
5 years, 10 months ago (2015-02-03 11:22:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891883002/20001
5 years, 10 months ago (2015-02-03 18:07:43 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 18:10:37 UTC) #8
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 18:11:19 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4adea21c6771ac1aaa6260524c3c283e85415672
Cr-Commit-Position: refs/heads/master@{#314366}

Powered by Google App Engine
This is Rietveld 408576698