Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 891873002: Add method for removing bookmark image data. (Closed)

Created:
5 years, 10 months ago by Rune Fevang
Modified:
5 years, 10 months ago
CC:
chromium-reviews, noyau+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add method for removing bookmark image data. Removes all image data associated with the bookmark, and sets the user_removed_image flag so the server won't attempt to set a new image for the bookmark. BUG=434436 Committed: https://crrev.com/950b89fb23bce3b60e02bcdcccfa7e75c345dc31 Cr-Commit-Position: refs/heads/master@{#314613}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M components/enhanced_bookmarks/enhanced_bookmark_model.h View 1 chunk +4 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/enhanced_bookmark_model_unittest.cc View 2 chunks +22 lines, -0 lines 0 comments Download
M components/enhanced_bookmarks/proto/metadata.proto View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Rune Fevang
5 years, 10 months ago (2015-01-31 00:02:32 UTC) #2
noyau (Ping after 24h)
lgtm
5 years, 10 months ago (2015-02-04 10:45:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891873002/1
5 years, 10 months ago (2015-02-04 19:08:02 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-04 20:06:14 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-04 20:08:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/950b89fb23bce3b60e02bcdcccfa7e75c345dc31
Cr-Commit-Position: refs/heads/master@{#314613}

Powered by Google App Engine
This is Rietveld 408576698