Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 891843002: Don't set up an autorelease pool in ContentMainRunner on iOS (Closed)

Created:
5 years, 10 months ago by stuartmorgan
Modified:
5 years, 10 months ago
Reviewers:
agl
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't set up an autorelease pool in ContentMainRunner on iOS This causes crashes if the shutdown path is used on iOS, because on iOS there's already a higher-level autorelease pool by the time this code can be run. BUG=None Committed: https://crrev.com/839634ad8f32b814c2829d912bfb26b17fe03ac7 Cr-Commit-Position: refs/heads/master@{#314021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M content/app/content_main_runner.cc View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
stuartmorgan
This upstreams minor forking from the iOS tree.
5 years, 10 months ago (2015-01-30 21:15:51 UTC) #2
agl
lgtm
5 years, 10 months ago (2015-01-30 21:32:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891843002/1
5 years, 10 months ago (2015-01-30 22:22:26 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 23:14:14 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 23:15:32 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/839634ad8f32b814c2829d912bfb26b17fe03ac7
Cr-Commit-Position: refs/heads/master@{#314021}

Powered by Google App Engine
This is Rietveld 408576698