Issue 89183002: Revert of Leave fullscreen mode in an app window when ESC key is pressed.

Issue 89183002: Revert of Leave fullscreen mode in an app window when ESC key is pressed. (Closed)

Created:
7 years ago by Roger Tawa OOO till Jul 10th

Modified:
7 years ago

Reviewers:
koz (OOO until 15th September), mlamouri (slow - plz ping)

CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Revert of https://codereview.chromium.org/62763003/ Reason for revert: This CL broke interactive tests on mac: http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.6%20Tests%20%281%29&number=46945 TBR=koz@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=237404

Patch Set 1 #

Created: 7 years ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -351 lines)			Patch
M	apps/shell_window.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	apps/shell_window.cc	View	1 chunk	+0 lines, -30 lines	0 comments	Download
D	chrome/browser/apps/app_interactive_uitest.cc	View	1 chunk	+0 lines, -181 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/api/_permission_features.json	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/common/extensions/permissions/chrome_api_permissions.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/extensions/permissions/permission_set_unittest.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	chrome/test/data/extensions/platform_apps/leave_fullscreen/main.html	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/leave_fullscreen/main.js	View	1 chunk	+0 lines, -31 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/leave_fullscreen/manifest.json	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen/main.html	View	1 chunk	+0 lines, -9 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen/main.js	View	1 chunk	+0 lines, -55 lines	0 comments	Download
D	chrome/test/data/extensions/platform_apps/prevent_leave_fullscreen/manifest.json	View	1 chunk	+0 lines, -12 lines	0 comments	Download
M	extensions/common/permissions/api_permission.h	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Roger Tawa OOO till Jul 10th

Created Revert of Leave fullscreen mode in an app window when ESC key is pressed.

7 years ago (2013-11-26 20:49:15 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rogerta@chromium.org/89183002/1

7 years ago (2013-11-26 20:50:22 UTC) #2

Message was sent while issue was closed.

Change committed as 237404

Expand Messages | Collapse Messages