Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 891813003: Add support for correct Windows 10 version enumeration. (Closed)

Created:
5 years, 10 months ago by Will Harris
Modified:
5 years, 10 months ago
CC:
chromium-reviews, grt+watch_chromium.org, erikwright+watch_chromium.org, caitkp+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for correct Windows 10 version enumeration. BUG=454018 Committed: https://crrev.com/3181ba39ee787e1b40f4aea4be23f4f666ad0945 Cr-Commit-Position: refs/heads/master@{#314213}

Patch Set 1 #

Total comments: 2

Patch Set 2 : better comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M base/win/windows_version.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M base/win/windows_version.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/test/mini_installer/variable_expander.py View 2 chunks +2 lines, -1 line 0 comments Download
M chrome_elf/thunk_getter.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
Will Harris
PTAL
5 years, 10 months ago (2015-01-31 01:29:05 UTC) #2
robertshield
lgtm
5 years, 10 months ago (2015-01-31 02:34:21 UTC) #3
cpu_(ooo_6.6-7.5)
https://codereview.chromium.org/891813003/diff/1/base/win/windows_version.h File base/win/windows_version.h (right): https://codereview.chromium.org/891813003/diff/1/base/win/windows_version.h#newcode30 base/win/windows_version.h:30: VERSION_WIN10, // Windows 10 includes windows server 10? is ...
5 years, 10 months ago (2015-01-31 22:02:03 UTC) #4
Will Harris
PTAL https://codereview.chromium.org/891813003/diff/1/base/win/windows_version.h File base/win/windows_version.h (right): https://codereview.chromium.org/891813003/diff/1/base/win/windows_version.h#newcode30 base/win/windows_version.h:30: VERSION_WIN10, // Windows 10 On 2015/01/31 22:02:03, cpu ...
5 years, 10 months ago (2015-02-01 21:31:08 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
5 years, 10 months ago (2015-02-02 23:03:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891813003/20001
5 years, 10 months ago (2015-02-02 23:03:30 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-02 23:07:27 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 23:08:11 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/3181ba39ee787e1b40f4aea4be23f4f666ad0945
Cr-Commit-Position: refs/heads/master@{#314213}

Powered by Google App Engine
This is Rietveld 408576698