Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 891803002: Padding tweak to permission bubble customization mode [Views] (Closed)

Created:
5 years, 10 months ago by felt
Modified:
5 years, 10 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews, tfarina, groby-ooo-7-16
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Padding tweak to permission bubble customization mode [Views] Adds a few extra pixels between the last permission and the "OK" button. BUG=451490 Committed: https://crrev.com/72474e08533cc3c7d99012db12fd3c1462ccbf08 Cr-Commit-Position: refs/heads/master@{#314117}

Patch Set 1 #

Patch Set 2 : Memory fail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/views/website_settings/permissions_bubble_view.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
felt
markus, PTAL. trivial change to the permission bubble to add some more spacing, as per ...
5 years, 10 months ago (2015-01-30 21:28:58 UTC) #2
markusheintz_
On 2015/01/30 21:28:58, felt wrote: > markus, PTAL. trivial change to the permission bubble to ...
5 years, 10 months ago (2015-02-02 08:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891803002/20001
5 years, 10 months ago (2015-02-02 09:00:00 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-02 09:02:55 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-02 09:03:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/72474e08533cc3c7d99012db12fd3c1462ccbf08
Cr-Commit-Position: refs/heads/master@{#314117}

Powered by Google App Engine
This is Rietveld 408576698