Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Unified Diff: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc

Issue 891793002: Take a Profile when adding an incident to the incident reporting service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: this time Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc
diff --git a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc
index 547fb0973d0341d3f3c741dd5e540e903a7995ff..9571f0c54654a67d8fd97aefa5ede19c0349db1c 100644
--- a/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc
+++ b/chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc
@@ -12,9 +12,16 @@
#include "base/memory/scoped_vector.h"
#include "base/values.h"
#include "chrome/browser/safe_browsing/incident_reporting/incident.h"
+#include "chrome/browser/safe_browsing/incident_reporting/mock_incident_receiver.h"
#include "chrome/common/safe_browsing/csd.pb.h"
+#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+using ::testing::_;
+using ::testing::IsNull;
+using ::testing::NiceMock;
+using ::testing::WithArg;
+
// A basic test harness that creates a delegate instance for which it stores all
// incidents. Tests can push data to the delegate and verify that the test
// instance was provided with the expected data.
@@ -30,13 +37,12 @@ class PreferenceValidationDelegateTest : public testing::Test {
testing::Test::SetUp();
invalid_keys_.push_back(std::string("one"));
invalid_keys_.push_back(std::string("two"));
+ scoped_ptr<safe_browsing::MockIncidentReceiver> receiver(
+ new NiceMock<safe_browsing::MockIncidentReceiver>());
+ ON_CALL(*receiver, DoAddIncidentForProfile(IsNull(), _))
+ .WillByDefault(WithArg<1>(TakeIncidentToVector(&incidents_)));
instance_.reset(new safe_browsing::PreferenceValidationDelegate(
- base::Bind(&PreferenceValidationDelegateTest::AddIncident,
- base::Unretained(this))));
- }
-
- void AddIncident(scoped_ptr<safe_browsing::Incident> incident) {
- incidents_.push_back(incident.release());
+ nullptr, receiver.Pass()));
}
static void ExpectValueStatesEquate(

Powered by Google App Engine
This is Rietveld 408576698