Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 891763003: Merge to XFA: track formhandles in embeddder test class itself (Closed)

Created:
5 years, 10 months ago by Tom Sepez
Modified:
5 years, 10 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Merge to XFA: track formhandles in embeddder test class itself TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/da8189e65547f87a9c7ba3ebb72f78ecdb47e120

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -55 lines) Patch
M fpdfsdk/src/fpdftext_embeddertest.cpp View 5 chunks +4 lines, -12 lines 0 comments Download
M fpdfsdk/src/fpdfview_embeddertest.cpp View 1 chunk +3 lines, -5 lines 0 comments Download
M testing/embedder_test.h View 2 chunks +9 lines, -12 lines 0 comments Download
M testing/embedder_test.cpp View 4 chunks +22 lines, -26 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Merge.
5 years, 10 months ago (2015-01-30 22:41:26 UTC) #2
Tom Sepez
Committed patchset #1 (id:1) manually as da8189e65547f87a9c7ba3ebb72f78ecdb47e120 (presubmit successful).
5 years, 10 months ago (2015-01-30 22:41:53 UTC) #3
Lei Zhang
5 years, 10 months ago (2015-01-30 22:58:34 UTC) #4
Message was sent while issue was closed.
lgtm, but the embeddddders are back.

Powered by Google App Engine
This is Rietveld 408576698