Make it possible to debug Release builds on rooted phones

build/android/adb_gdb

 #!/bin/bash
 #
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 #
 
 # A generic script used to attach to a running Chromium process and
 # debug it. Most users should not use this directly, but one of the
 # wrapper scripts like adb_gdb_content_shell
 #
 # Use --help to print full usage instructions.
 #
 
 PROGNAME=$(basename "$0")
 PROGDIR=$(dirname "$0")
 
 # Location of Chromium-top-level sources.
 CHROMIUM_SRC=$(cd "$PROGDIR"/../.. >/dev/null && pwd 2>/dev/null)
 
 # Location of Chromium out/ directory.
 if [ -z "$CHROMIUM_OUT_DIR" ]; then
   CHROMIUM_OUT_DIR=out
 fi
 
 TMPDIR=
 GDBSERVER_PIDFILE=
 TARGET_GDBSERVER=
+COMMAND_PREFIX=
 
 clean_exit () {
   if [ "$TMPDIR" ]; then
     GDBSERVER_PID=$(cat $GDBSERVER_PIDFILE 2>/dev/null)
     if [ "$GDBSERVER_PID" ]; then
       log "Killing background gdbserver process: $GDBSERVER_PID"
       kill -9 $GDBSERVER_PID >/dev/null 2>&1
     fi
     if [ "$TARGET_GDBSERVER" ]; then
       log "Removing target gdbserver binary: $TARGET_GDBSERVER."
-      "$ADB" shell run-as "$PACKAGE_NAME" rm "$TARGET_GDBSERVER" >/dev/null 2>&1
+      "$ADB" shell "$COMMAND_PREFIX" rm "$TARGET_GDBSERVER" >/dev/null 2>&1
     fi
     log "Cleaning up: $TMPDIR"
     rm -rf "$TMPDIR"
   fi
   trap "" EXIT
   exit $1
 }
 
 # Ensure clean exit on Ctrl-C or normal exit.
 trap "clean_exit 1" INT HUP QUIT TERM
@@ skipping 678 matching lines @@
   SYMBOL_DIR=$CHROMIUM_SRC/$CHROMIUM_OUT_DIR/$SUBDIR
   log "Auto-config: --symbol-dir=$SYMBOL_DIR"
 }
 
 if [ -z "$SYMBOL_DIR" ]; then
   detect_symbol_dir "$BUILDTYPE"
 fi
 
 # Allow several concurrent debugging sessions
 TARGET_GDBSERVER=/data/data/$PACKAGE_NAME/gdbserver-adb-gdb-$TMP_ID
-TMP_TARGET_GDBSERVER=/data/local/tmp/gdbserver-adb-gdb-$TMP_ID
+ROOT_TARGET_GDBSERVER=/data/local/tmp/gdbserver-adb-gdb-$TMP_ID
 
 # Return the build fingerprint contained in a build.prop file.
 # $1: path to build.prop file
 get_build_fingerprint_from () {
   cat "$1" | grep -e '^ro.build.fingerprint=' | cut -d= -f2
 }
 
 
 ORG_PULL_LIBS_DIR=$PULL_LIBS_DIR
 PULL_LIBS_DIR=${PULL_LIBS_DIR:-$DEFAULT_PULL_LIBS_DIR}
@@ skipping 151 matching lines @@
 SOLIB_DIRS=$(find $PULL_LIBS_DIR -mindepth 1 -maxdepth 4 -type d | \
              grep -v "^$" | tr '\n' ':')
 
 # This is a re-implementation of gdbclient, where we use compatible
 # versions of gdbserver and $GDBNAME to ensure that everything works
 # properly.
 #
 
 # Push gdbserver to the device
 log "Pushing gdbserver $GDBSERVER to $TARGET_GDBSERVER"
-adb push $GDBSERVER $TMP_TARGET_GDBSERVER &>/dev/null
-adb shell run-as $PACKAGE_NAME cp $TMP_TARGET_GDBSERVER .

[jbudorick, 2015/01/30 16:43:23]

I should've been more clear: why doesn't this CL _only_ use adb shell
$COMMAND_PREFIX cp here instead of adding the if/else and renaming
TMP_TARGET_GDBSERVER to ROOT_TARGET_GDBSERVER?

[jbudorick, 2015/02/02 16:14:46]

I did see the patch. This was my comment.

-adb shell rm $TMP_TARGET_GDBSERVER
+adb push $GDBSERVER $ROOT_TARGET_GDBSERVER &>/dev/null
+if ["$COMMAND_PREFIX" == "$SU_PREFIX"]; then
+  TARGET_GDBSERVER=$ROOT_TARGET_GDBSERVER
+else
+  log "Moving gdbserver to $TARGET_GDBSERVER"
+  adb shell $COMMAND_PREFIX cp $ROOT_TARGET_GDBSERVER $TARGET_GDBSERVER
+  adb shell rm $ROOT_TARGET_GDBSERVER
+fi
 fail_panic "Could not copy gdbserver to the device!"
 
 PORT=5039
 HOST_PORT=$PORT
 TARGET_PORT=$PORT
 
 # Select correct app_process for architecture.
 case $TARGET_ARCH in
       arm|x86|mips) GDBEXEC=app_process;;
       arm64|x86_64) GDBEXEC=app_process64;;
@@ skipping 87 matching lines @@
 
 if [ "$VERBOSE" -gt 0 ]; then
   echo "### START $COMMANDS"
   cat $COMMANDS
   echo "### END $COMMANDS"
 fi
 
 log "Launching gdb client: $GDB $GDB_ARGS -x $COMMANDS"
 $GDB $GDB_ARGS -x $COMMANDS &&
 rm -f "$GDBSERVER_PIDFILE"