Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 891733002: Don't collect 'other tracks' in HTMLMediaElement::configureTextTracks (Closed)

Created:
5 years, 10 months ago by fs
Modified:
5 years, 10 months ago
Reviewers:
philipj_slow
CC:
blink-reviews, nessy, philipj_slow, gasubic, fs, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, blink-reviews-html_chromium.org, vcarbune.chromium
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't collect 'other tracks' in HTMLMediaElement::configureTextTracks After having processed 'subtitles', 'captions', 'descriptions' and 'chapters' tracks, there's only 'metadata' tracks left (no more kinds are currently defined). This means that the 'otherTracks' set will always be empty. Remove it an add an assert. Also take the opportunity to rename the various methods involved to match the match the names of the spec. algorithms they implement. configureTextTracks -> honorUserPreferencesForAutomaticTextTrackSelection configureTextTrackGroup -> performAutomaticTextTrackSelection configureMetadataTextTrackGroup -> enableDefaultMetadataTextTracks Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=189262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -30 lines) Patch
M Source/core/html/HTMLMediaElement.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/html/HTMLMediaElement.cpp View 10 chunks +25 lines, -27 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
fs
Hope you like the new names! =D
5 years, 10 months ago (2015-01-30 13:32:32 UTC) #2
philipj_slow
lgtm They're delightful!
5 years, 10 months ago (2015-01-30 15:29:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891733002/1
5 years, 10 months ago (2015-01-30 15:30:15 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 16:05:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=189262

Powered by Google App Engine
This is Rietveld 408576698