Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: tools/cygprofile/check_orderfile.py

Issue 891713002: Script checking that the observed function order matches an orderfile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/cygprofile/check_orderfile_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/cygprofile/check_orderfile.py
diff --git a/tools/cygprofile/check_orderfile.py b/tools/cygprofile/check_orderfile.py
new file mode 100755
index 0000000000000000000000000000000000000000..c1870aeecf2ba27806f42ca1f1985d0bf8080934
--- /dev/null
+++ b/tools/cygprofile/check_orderfile.py
@@ -0,0 +1,81 @@
+#!/usr/bin/python
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""Check that symbols are ordered into a binary as they appear in the orderfile.
+"""
+
+import logging
+import sys
+
+import patch_orderfile
+import symbol_extractor
+
+
+_MAX_WARNINGS_TO_PRINT = 200
+
+
+def _CountMisorderedSymbols(symbols, symbol_infos):
+ """Count the number of misordered symbols, and log them.
+
+ Args:
+ symbols: ordered sequence of symbols from the orderfile
+ symbol_infos: ordered list of SymbolInfo from the binary
+
+ Returns:
+ (misordered_pairs_count, matched_symbols_count, unmatched_symbols_count)
+ """
+ name_to_symbol_info = symbol_extractor.CreateNameToSymbolInfo(symbol_infos)
+ matched_symbol_infos = []
+ missing_count = 0
+ misordered_count = 0
+
+ # Find the SymbolInfo matching the orderfile symbols in the binary.
+ for symbol in symbols:
+ if symbol in name_to_symbol_info:
+ matched_symbol_infos.append(name_to_symbol_info[symbol])
+ else:
+ missing_count += 1
+ if missing_count < _MAX_WARNINGS_TO_PRINT:
+ logging.warning('Symbol "%s" is in the orderfile, not in the binary' %
+ symbol)
+ logging.info('%d matched symbols, %d un-matched (Only the first %d unmatched'
+ ' symbols are shown)' % (
+ len(matched_symbol_infos), missing_count,
+ _MAX_WARNINGS_TO_PRINT))
+
+ # In the order of the orderfile, find all the symbols that are at an offset
+ # smaller than their immediate predecessor, and record the pair.
+ previous_symbol_info = symbol_extractor.SymbolInfo(
+ name='', offset=-1, size=0, section='')
+ for symbol_info in matched_symbol_infos:
+ if symbol_info.offset < previous_symbol_info.offset:
+ logging.warning("Misordered pair: %s - %s" % (
+ str(previous_symbol_info), str(symbol_info)))
+ misordered_count += 1
+ previous_symbol_info = symbol_info
+ return (misordered_count, len(matched_symbol_infos), missing_count)
+
+
+def main():
+ if len(sys.argv) != 4 and len(sys.argv) != 3:
+ logging.error('Usage: check_orderfile.py binary orderfile [threshold]')
+ return 1
+ (binary_filename, orderfile_filename) = sys.argv[1:3]
+ threshold = 0
+ if len(sys.argv) == 4:
+ threshold = int(sys.argv[3])
+
+ symbols = patch_orderfile.GetSymbolsFromOrderfile(orderfile_filename)
+ symbol_infos = symbol_extractor.SymbolInfosFromBinary(binary_filename)
+ # Missing symbols is not an error since some of them can be eliminated through
+ # inlining.
+ (misordered_pairs_count, _, _) = _CountMisorderedSymbols(
+ symbols, symbol_infos)
+ return misordered_pairs_count > threshold
+
+
+if __name__ == '__main__':
+ logging.basicConfig(level=logging.INFO)
+ sys.exit(main())
« no previous file with comments | « no previous file | tools/cygprofile/check_orderfile_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698