Script checking that the observed function order matches an orderfile.

tools/cygprofile/patch_orderfile.py

Index: tools/cygprofile/patch_orderfile.py
diff --git a/tools/cygprofile/patch_orderfile.py b/tools/cygprofile/patch_orderfile.py
index d898b99e15ccf8e35365069ea485290b660b0b1a..95841d4e3e53ca2fc8846b1f4ed3b5f557c37800 100755
--- a/tools/cygprofile/patch_orderfile.py
+++ b/tools/cygprofile/patch_orderfile.py
@@ -122,7 +122,7 @@ def _GetSymbolsFromStream(lines):
   return symbols
 
 
-def _GetSymbolsFromOrderfile(filename):
+def GetSymbolsFromOrderfile(filename):

[pasko, 2015/02/02 14:32:37]

thanks for this change. So this natirally leads me to ask for more :)

What order of functions should be used? Are there any python/google/whatever
guidelines? Maybe exported functions being on top/bottom?

In Chromium C++ we have a guideline of having the functions defined in the .cc
file in the _same_ order as declared in the header. I don't particularly like
it, but it leads to less surprises for _some_ devs.

[Benoit L, 2015/02/02 15:37:05]

I would argue that once a function has been written, it should not move within
its file for no reason, to keep the noise in "git blame" output low. So I would
leave this one alone for now.

[pasko, 2015/02/02 15:52:28]

git blame -C
?

but yeah, I don't like moving functions around unnecessarily either. Here it's a
bit of a special case, where refactoring moved a lot of things anyway, and, as
we know, the primary purpose of refactoring is how the final version of the code
looks, so .. spoiled git blame is really not an issue.

   """Return the symbols from an orderfile.
 
   Args:
@@ -211,7 +211,7 @@ def main(argv):
   binary_filename = argv[2]
   (offset_to_symbol_infos, name_to_symbol_infos) = _GroupSymbolInfosFromBinary(
       binary_filename)
-  profiled_symbols = _GetSymbolsFromOrderfile(orderfile_filename)
+  profiled_symbols = GetSymbolsFromOrderfile(orderfile_filename)
   expanded_symbols = _ExpandSymbols(
       profiled_symbols, name_to_symbol_infos, offset_to_symbol_infos)
   _PrintSymbolsWithPrefixes(expanded_symbols, sys.stdout)