tools/cygprofile/patch_orderfile.py - Issue 891713002: Script checking that the observed function order matches an orderfile.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/cygprofile/patch_orderfile.py

Issue 891713002: Script checking that the observed function order matches an orderfile. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Spacing, naming, unused imports. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/cygprofile/patch_orderfile.py

diff --git a/tools/cygprofile/patch_orderfile.py b/tools/cygprofile/patch_orderfile.py

index d898b99e15ccf8e35365069ea485290b660b0b1a..95841d4e3e53ca2fc8846b1f4ed3b5f557c37800 100755

--- a/tools/cygprofile/patch_orderfile.py

+++ b/tools/cygprofile/patch_orderfile.py

@@ -122,7 +122,7 @@ def _GetSymbolsFromStream(lines):

return symbols

-def _GetSymbolsFromOrderfile(filename):

+def GetSymbolsFromOrderfile(filename):

"""Return the symbols from an orderfile.

Args:

@@ -211,7 +211,7 @@ def main(argv):

binary_filename = argv[2]

(offset_to_symbol_infos, name_to_symbol_infos) = _GroupSymbolInfosFromBinary(

binary_filename)

- profiled_symbols = _GetSymbolsFromOrderfile(orderfile_filename)

+ profiled_symbols = GetSymbolsFromOrderfile(orderfile_filename)

expanded_symbols = _ExpandSymbols(

profiled_symbols, name_to_symbol_infos, offset_to_symbol_infos)

_PrintSymbolsWithPrefixes(expanded_symbols, sys.stdout)

« tools/cygprofile/check_orderfile_unittest.py ('K') | « tools/cygprofile/check_orderfile_unittest.py ('k') | no next file » | no next file with comments »