Issue 891703005: Improve Color32A_D565 quality at the expense of speed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 891703005: Improve Color32A_D565 quality at the expense of speed. (Closed)

Created:
5 years, 10 months ago by mtklein_C

Modified:
5 years, 10 months ago

Reviewers:

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Improve Color32A_D565 quality at the expense of speed. On Intel, Color32A_D565 is being autovectorized both before and after this CL, so it's a little hard to tell what's going on. The microbenchmarks take the expected big hit, and the worst case in SKPs is a 30% slowdown on desk_youtube.skp, which is dominated by Color32A_D565 in 565 mode. Fortunately / unfortunately, we've optimized this proc for NEON already. BUG=skia:

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -18 lines)			Patch
	M	src/core/SkBlitRow_D16.cpp	View		1 chunk	+3 lines, -18 lines	0 comments	Download

Messages

Total messages: 2 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Patchset #2 (id:20001) has been deleted

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages