Searchbox (empty) text focus fix (http://code.google.com/p/dart/issues/detail?id=819).

Searchbox (empty) text focus fix (http://code.google.com/p/dart/issues/detail?id=819).

See bug for details.  Net-net: deleting text in the search text area will now no longer punt you back to the previously active control (but ESC still will).

(NOTE: the OSX deactivate event special-handling logic appears to be defunct.  In the interest of better code hygiene I removed it. In the interest of lazyness I didn't bother creating a separate CL.)
 
Committed: https://code.google.com/p/dart/source/detail?r=2361

[messick, 2011-12-12 23:13:44]

lgtm

http://codereview.chromium.org/8917023/diff/1/editor/tools/plugins/com.google...
File
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/omni/OmniBoxControlContribution.java
(right):

http://codereview.chromium.org/8917023/diff/1/editor/tools/plugins/com.google...
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/omni/OmniBoxControlContribution.java:49:
private final class Popup extends OmniBoxPopup {
Why "final"?

[pquitslund, 2011-12-12 23:15:53]

On 2011/12/12 23:13:44, messick wrote:
> lgtm
> 
>
http://codereview.chromium.org/8917023/diff/1/editor/tools/plugins/com.google...
> File
>
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/omni/OmniBoxControlContribution.java
> (right):
> 
>
http://codereview.chromium.org/8917023/diff/1/editor/tools/plugins/com.google...
>
editor/tools/plugins/com.google.dart.tools.ui/src/com/google/dart/tools/ui/omni/OmniBoxControlContribution.java:49:
> private final class Popup extends OmniBoxPopup {
> Why "final"?

Great question.  The refactoring tool did it for me when I extracted the class. 
Since the class is private and really not meant for extension I left it as is. 
But not without taking a second to think about it!