pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart - Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Comments & some fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« pkg/compiler/lib/src/js_backend/namer.dart ('K') | « pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart ('k') | pkg/compiler/lib/src/js_emitter/old_emitter/class_emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

index a543208cb2a1265976f8a1e35b15227dbc561618..5112d10c9344cd752b42e38cd0ae0cbc81fdd8e4 100644

--- a/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

@@ -85,7 +85,7 @@ class Emitter implements emitterTask.Emitter {

}

js.PropertyAccess _globalPropertyAccess(Element element) {

- String name = namer.getNameX(element);

+ String name = namer.globalPropertyName(element);

js.PropertyAccess pa = new js.PropertyAccess.field(

new js.VariableUse(namer.globalObjectFor(element)),

name);

@@ -95,13 +95,13 @@ class Emitter implements emitterTask.Emitter {

@override

js.Expression isolateLazyInitializerAccess(FieldElement element) {

return js.js('#.#', [namer.globalObjectFor(element),

- namer.getLazyInitializerName(element)]);

+ namer.lazyInitializerName(element)]);

}

@override

js.Expression isolateStaticClosureAccess(FunctionElement element) {

return js.js('#.#()',

- [namer.globalObjectFor(element), namer.getStaticClosureName(element)]);

+ [namer.globalObjectFor(element), namer.staticClosureName(element)]);

}

@override