pkg/compiler/lib/src/js_backend/backend.dart - Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/backend.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Comments & some fixes Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/compiler.dart ('k') | pkg/compiler/lib/src/js_backend/constant_emitter.dart » ('j') | pkg/compiler/lib/src/js_backend/minify_namer.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_backend/backend.dart

diff --git a/pkg/compiler/lib/src/js_backend/backend.dart b/pkg/compiler/lib/src/js_backend/backend.dart

index 975581c922c175e6a839671ef8e12ffb6c41e3e3..1e5ade22cd7167712b67d58c5fb80f13aeda3046 100644

--- a/pkg/compiler/lib/src/js_backend/backend.dart

+++ b/pkg/compiler/lib/src/js_backend/backend.dart

@@ -539,7 +539,7 @@ class JavaScriptBackend extends Backend {

String registerOneShotInterceptor(Selector selector) {

Set<ClassElement> classes = getInterceptedClassesOn(selector.name);

- String name = namer.getOneShotInterceptorName(selector, classes);

+ String name = namer.nameForGetOneShotInterceptor(selector, classes);

if (!oneShotInterceptors.containsKey(name)) {

registerSpecializedGetInterceptor(classes);

oneShotInterceptors[name] = selector;

@@ -738,7 +738,7 @@ class JavaScriptBackend extends Backend {

}

void registerSpecializedGetInterceptor(Set<ClassElement> classes) {

- String name = namer.getInterceptorName(getInterceptorMethod, classes);

+ String name = namer.nameForGetInterceptor(classes);

if (classes.contains(jsInterceptorClass)) {

// We can't use a specialized [getInterceptorMethod], so we make

// sure we emit the one with all checks.