Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: MEGAPATCH Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index 0d4b38911d9bf6777dc1306ee7759f5b0aa1d29d..887b8fa57e35a7d36e188dda95df6d9a1833d82a 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -1492,8 +1492,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void visitInterceptor(HInterceptor node) {
registry.registerSpecializedGetInterceptor(node.interceptedClasses);
- String name = backend.namer.getInterceptorName(
- backend.getInterceptorMethod, node.interceptedClasses);
+ String name = backend.namer.nameForGetInterceptor(node.interceptedClasses);
var isolate = new js.VariableUse(
backend.namer.globalObjectFor(backend.interceptorsLibrary));
use(node.receiver);
@@ -1539,7 +1538,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void visitInvokeConstructorBody(HInvokeConstructorBody node) {
use(node.inputs[0]);
js.Expression object = pop();
- String methodName = backend.namer.getNameOfInstanceMember(node.element);
+ String methodName = backend.namer.instanceMethodName(node.element);
List<js.Expression> arguments = visitArguments(node.inputs);
push(js.propertyCall(object, methodName, arguments), node);
registry.registerStaticUse(node.element);
@@ -1679,7 +1678,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
methodName = backend.namer.invocationName(selector);
} else {
assert(invariant(node, compiler.hasIncrementalSupport));
- methodName = backend.namer.getNameOfInstanceMember(superMethod);
+ methodName = backend.namer.instanceMethodName(superMethod);
}
push(js.js('#.#.call(#)',
[backend.emitter.prototypeAccess(superClass,
@@ -1690,7 +1689,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
use(node.receiver);
push(
js.js('#.#(#)', [
- pop(), backend.namer.getNameOfAliasedSuperMember(superMethod),
+ pop(), backend.namer.aliasedSuperMemberPropertyName(superMethod),
visitArguments(node.inputs, start: 1)]), // Skip receiver argument.
node);
}
@@ -2633,7 +2632,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
} else {
backend.emitter.registerReadTypeVariable(element);
push(js.js('#.#()',
- [pop(), backend.namer.readTypeVariableName(element)]));
+ [pop(), backend.namer.typeVariableName(element)]));
}
} else {
push(js.js('#(#)', [

Powered by Google App Engine
This is Rietveld 408576698