Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: pkg/compiler/lib/src/ssa/codegen.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/ssa_tracer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/codegen.dart
diff --git a/pkg/compiler/lib/src/ssa/codegen.dart b/pkg/compiler/lib/src/ssa/codegen.dart
index 21387ea8f698d760324afafc74d0e37e5549e16d..752df171597b0a3b6a770cc34b04ca12b3749807 100644
--- a/pkg/compiler/lib/src/ssa/codegen.dart
+++ b/pkg/compiler/lib/src/ssa/codegen.dart
@@ -1473,8 +1473,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void visitInterceptor(HInterceptor node) {
registry.registerSpecializedGetInterceptor(node.interceptedClasses);
- String name = backend.namer.getInterceptorName(
- backend.getInterceptorMethod, node.interceptedClasses);
+ String name = backend.namer.nameForGetInterceptor(node.interceptedClasses);
var isolate = new js.VariableUse(
backend.namer.globalObjectFor(backend.interceptorsLibrary));
use(node.receiver);
@@ -1520,7 +1519,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
void visitInvokeConstructorBody(HInvokeConstructorBody node) {
use(node.inputs[0]);
js.Expression object = pop();
- String methodName = backend.namer.getNameOfInstanceMember(node.element);
+ String methodName = backend.namer.instanceMethodName(node.element);
List<js.Expression> arguments = visitArguments(node.inputs);
push(js.propertyCall(object, methodName, arguments), node);
registry.registerStaticUse(node.element);
@@ -1660,7 +1659,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
methodName = backend.namer.invocationName(selector);
} else {
assert(invariant(node, compiler.hasIncrementalSupport));
- methodName = backend.namer.getNameOfInstanceMember(superMethod);
+ methodName = backend.namer.instanceMethodName(superMethod);
}
push(js.js('#.#.call(#)',
[backend.emitter.prototypeAccess(superClass,
@@ -1671,7 +1670,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
use(node.receiver);
push(
js.js('#.#(#)', [
- pop(), backend.namer.getNameOfAliasedSuperMember(superMethod),
+ pop(), backend.namer.aliasedSuperMemberPropertyName(superMethod),
visitArguments(node.inputs, start: 1)]), // Skip receiver argument.
node);
}
@@ -2632,7 +2631,7 @@ class SsaCodeGenerator implements HVisitor, HBlockInformationVisitor {
} else {
backend.emitter.registerReadTypeVariable(element);
push(js.js('#.#()',
- [pop(), backend.namer.readTypeVariableName(element)]));
+ [pop(), backend.namer.nameForReadTypeVariable(element)]));
}
} else {
push(js.js('#(#)', [
« no previous file with comments | « pkg/compiler/lib/src/ssa/builder.dart ('k') | pkg/compiler/lib/src/ssa/ssa_tracer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698