Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Unified Diff: pkg/compiler/lib/src/js_backend/runtime_types.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Rebase Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/runtime_types.dart
diff --git a/pkg/compiler/lib/src/js_backend/runtime_types.dart b/pkg/compiler/lib/src/js_backend/runtime_types.dart
index eb4616c3695eecac19cf2224fe8ef48d41258651..4e8e3688ed107a195ebc13f246a13c34f212cab5 100644
--- a/pkg/compiler/lib/src/js_backend/runtime_types.dart
+++ b/pkg/compiler/lib/src/js_backend/runtime_types.dart
@@ -33,7 +33,7 @@ class RuntimeTypes {
JavaScriptBackend get backend => compiler.backend;
String get getFunctionThatReturnsNullName
- => backend.namer.getMappedInstanceName('functionThatReturnsNull');
+ => backend.namer.internalGlobal('functionThatReturnsNull');
RuntimeTypes(Compiler compiler)
: this.compiler = compiler,
@@ -401,7 +401,7 @@ class RuntimeTypes {
String getTypeRepresentationForTypeConstant(DartType type) {
JavaScriptBackend backend = compiler.backend;
Namer namer = backend.namer;
- if (type.isDynamic) return namer.getRuntimeTypeName(null);
+ if (type.isDynamic) return namer.runtimeTypeName(null);
String name = namer.uniqueNameForTypeConstantElement(type.element);
if (!type.element.isClass) return name;
InterfaceType interface = type;
@@ -541,7 +541,7 @@ class RuntimeTypes {
getTypeEncoding(type, alwaysGenerateFunction: true);
if (contextClass != null) {
JavaScriptBackend backend = compiler.backend;
- String contextName = backend.namer.getNameOfClass(contextClass);
+ String contextName = backend.namer.className(contextClass);
return js('function () { return #(#, #, #); }',
[ backend.emitter.staticFunctionAccess(backend.getComputeSignature()),
encoding, this_, js.string(contextName) ]);
« no previous file with comments | « pkg/compiler/lib/src/js_backend/namer.dart ('k') | pkg/compiler/lib/src/js_emitter/class_stub_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698