Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

Issue 891673003: dart2js: Refactoring, documentation, and a few bugfixes in Namer class. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Typo and TODO about clash in named parameters Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
index e79e424e656d1975df979157d4d2a51211ad82eb..703c909e134f2fb602d5a3b8e01281d68682e44e 100644
--- a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart
@@ -117,7 +117,7 @@ class ContainerBuilder extends CodeEmitterHelper {
} else if (member.isInstanceMember) {
if (needsSuperGetter(member)) {
ClassElement superClass = member.enclosingClass;
- String methodName = namer.getNameOfInstanceMember(member);
+ String methodName = namer.instanceMethodName(member);
// When redirecting, we must ensure that we don't end up in a subclass.
// We thus can't just invoke `this.foo$1.call(filledInArguments)`.
// Instead we need to call the statically resolved target.
@@ -131,7 +131,7 @@ class ContainerBuilder extends CodeEmitterHelper {
} else {
body = js.statement(
'return this.#(#);',
- [namer.getNameOfInstanceMember(member), argumentsBuffer]);
+ [namer.instanceMethodName(member), argumentsBuffer]);
}
} else {
body = js.statement('return #(#)',
@@ -267,7 +267,7 @@ class ContainerBuilder extends CodeEmitterHelper {
if (member.isAbstract) return null;
jsAst.Expression code = backend.generatedCode[member];
if (code == null) return null;
- String name = namer.getNameOfMember(member);
+ String name = namer.getNameOfMethod(member);
FunctionSignature parameters = member.functionSignature;
bool needsStubs = !parameters.optionalParameters.isEmpty;
@@ -296,7 +296,7 @@ class ContainerBuilder extends CodeEmitterHelper {
compiler.codegenWorld.hasInvokedGetter(member, compiler.world) ||
(canBeReflected && !member.isOperator);
assert(!needsSuperGetter(member) || canTearOff);
- tearOffName = namer.getterName(member);
+ tearOffName = namer.getterForElement(member);
}
} else {
canTearOff =

Powered by Google App Engine
This is Rietveld 408576698