dart2js: Refactoring, documentation, and a few bugfixes in Namer class.

pkg/compiler/lib/src/js_emitter/new_emitter/emitter.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.new_js_emitter.emitter;
 
 import '../program_builder.dart' show ProgramBuilder;
 import '../model.dart';
 import 'model_emitter.dart';
 import '../../common.dart';
@@ skipping 73 matching lines @@
   js.Expression generateFunctionThatReturnsNull() {
     return js.js('function() {}');
   }
 
   @override
   js.Expression constantReference(ConstantValue value) {
     return _emitter.constantEmitter.reference(value);
   }
 
   js.PropertyAccess _globalPropertyAccess(Element element) {
-     String name = namer.getNameX(element);
+     String name = namer.globalPropertyName(element);
      js.PropertyAccess pa = new js.PropertyAccess.field(
          new js.VariableUse(namer.globalObjectFor(element)),
          name);
      return pa;
    }
 
   @override
   js.Expression isolateLazyInitializerAccess(FieldElement element) {
     return js.js('#.#', [namer.globalObjectFor(element),
-                         namer.getLazyInitializerName(element)]);
+                         namer.lazyInitializerName(element)]);
   }
 
   @override
   js.Expression isolateStaticClosureAccess(FunctionElement element) {
     return js.js('#.#()',
-        [namer.globalObjectFor(element), namer.getStaticClosureName(element)]);
+        [namer.globalObjectFor(element), namer.staticClosureName(element)]);
   }
 
   @override
   js.PropertyAccess staticFieldAccess(FieldElement element) {
     return _globalPropertyAccess(element);
   }
 
   @override
   js.PropertyAccess staticFunctionAccess(FunctionElement element) {
     return _globalPropertyAccess(element);
@@ skipping 22 matching lines @@
   @override
   js.Expression typeAccess(Element element) {
     // TODO(floitsch): minify 'ensureResolved'.
     // TODO(floitsch): don't emit `ensureResolved` for eager classes.
     return js.js('#.ensureResolved()', _globalPropertyAccess(element));
   }
 
   @override
   void invalidateCaches() {}
 }