Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 891663004: Disable ASan instrumentation of select sandbox code on Windows (Closed)

Created:
5 years, 10 months ago by Timur Iskhodzhanov
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable ASan instrumentation of select sandbox code on Windows This patch allows sbox_unittests and sbox_integration_tests to pass under ASan/Win BUG=382867 NOTRY=true Committed: https://crrev.com/bd9087b7c5fc0eafab167e994d2f9c142bebb300 Cr-Commit-Position: refs/heads/master@{#313912}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A tools/memory/asan/blacklist_win.txt View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Timur Iskhodzhanov
5 years, 10 months ago (2015-01-30 13:59:11 UTC) #2
Alexander Potapenko
LGTM
5 years, 10 months ago (2015-01-30 14:00:36 UTC) #3
Timur Iskhodzhanov
Jochen, Can you please review the tiny change to build/common.gypi? Thanks!
5 years, 10 months ago (2015-01-30 14:03:29 UTC) #5
jochen (gone - plz use gerrit)
lgtm
5 years, 10 months ago (2015-01-30 14:04:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891663004/1
5 years, 10 months ago (2015-01-30 14:07:59 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-01-30 14:08:53 UTC) #9
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 14:09:52 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bd9087b7c5fc0eafab167e994d2f9c142bebb300
Cr-Commit-Position: refs/heads/master@{#313912}

Powered by Google App Engine
This is Rietveld 408576698