Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(359)

Unified Diff: base/json/json_file_value_serializer.cc

Issue 891663003: Log pref file size histogram on read rather than on write. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nits / format / only log on successful read Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_file_value_serializer.h ('k') | base/prefs/json_pref_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_file_value_serializer.cc
diff --git a/base/json/json_file_value_serializer.cc b/base/json/json_file_value_serializer.cc
index d60f800cfcfbb9235fc62fc050feb98c87a54740..71033f638200fbff9ce7dcbd247bf91e1a7597a3 100644
--- a/base/json/json_file_value_serializer.cc
+++ b/base/json/json_file_value_serializer.cc
@@ -15,6 +15,16 @@ const char JSONFileValueSerializer::kCannotReadFile[] = "Can't read file.";
const char JSONFileValueSerializer::kFileLocked[] = "File locked.";
const char JSONFileValueSerializer::kNoSuchFile[] = "File doesn't exist.";
+JSONFileValueSerializer::JSONFileValueSerializer(
+ const base::FilePath& json_file_path)
+ : json_file_path_(json_file_path),
+ allow_trailing_comma_(false),
+ last_read_size_(0U) {
+}
+
+JSONFileValueSerializer::~JSONFileValueSerializer() {
+}
+
bool JSONFileValueSerializer::Serialize(const base::Value& root) {
return SerializeInternal(root, false);
}
@@ -59,6 +69,8 @@ int JSONFileValueSerializer::ReadFileToString(std::string* json_string) {
else
return JSON_CANNOT_READ_FILE;
}
+
+ last_read_size_ = json_string->size();
return JSON_NO_ERROR;
}
« no previous file with comments | « base/json/json_file_value_serializer.h ('k') | base/prefs/json_pref_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698