Log pref file size histogram on read rather than on write.

base/json/json_file_value_serializer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
 #define BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_
 
 #include <string>
 
 #include "base/base_export.h"
 #include "base/basictypes.h"
 #include "base/files/file_path.h"
 #include "base/values.h"
 
 class BASE_EXPORT JSONFileValueSerializer : public base::ValueSerializer {
  public:
-  // json_file_patch is the path of a file that will be source of the
+  // |json_file_path_| is the path of a file that will be source of the
   // deserialization or the destination of the serialization.
   // When deserializing, the file should exist, but when serializing, the
   // serializer will attempt to create the file at the specified location.
-  explicit JSONFileValueSerializer(const base::FilePath& json_file_path)
-    : json_file_path_(json_file_path),
-      allow_trailing_comma_(false) {}
+  // If |histogram_suffix| is non-empty, will log a
+  // "Settings.JsonDataSizeKilobytes.|histogram_suffix|" UMA histogram with the
+  // size of the content read from disk while deserializing.
+  JSONFileValueSerializer(const base::FilePath& json_file_path,
+                          const std::string& histogram_suffix);

[Nico, 2015/01/30 18:46:28]

Why does a json library need to expose histograms in its public api?

Even the previous histogram code in the json implementation looks pretty fishy
to me (I hadn't seen it before), but at least it was some internal thing.

 
-  ~JSONFileValueSerializer() override {}
+  // Constructs a JSONFileValueSerializer as above but with an empty
+  // |histogram_suffix|.
+  explicit JSONFileValueSerializer(const base::FilePath& json_file_path);
+
+  ~JSONFileValueSerializer() override;
 
   // DO NOT USE except in unit tests to verify the file was written properly.
   // We should never serialize directly to a file since this will block the
   // thread. Instead, serialize to a string and write to the file you want on
   // the file thread.
   //
   // Attempt to serialize the data structure represented by Value into
   // JSON.  If the return value is true, the result will have been written
   // into the file whose name was passed into the constructor.
   bool Serialize(const base::Value& root) override;
@@ skipping 31 matching lines @@
   // be a JsonFileError.
   static const char* GetErrorMessageForCode(int error_code);
 
   void set_allow_trailing_comma(bool new_value) {
     allow_trailing_comma_ = new_value;
   }
 
  private:
   bool SerializeInternal(const base::Value& root, bool omit_binary_values);
 
-  base::FilePath json_file_path_;
+  const base::FilePath json_file_path_;
   bool allow_trailing_comma_;
+  const std::string histogram_suffix_;
 
   // A wrapper for ReadFileToString which returns a non-zero JsonFileError if
   // there were file errors.
   int ReadFileToString(std::string* json_string);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(JSONFileValueSerializer);
 };
 
 #endif  // BASE_JSON_JSON_FILE_VALUE_SERIALIZER_H_