tools/metrics/histograms/histograms.xml - Issue 891663003: Log pref file size histogram on read rather than on write.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 891663003: Log pref file size histogram on read rather than on write. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: nits / format / only log on successful read Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 60f301efb0e27b52649771cf18b8f798fddccf53..3ef347e09cc434b113d0988a5042526fd6a58402 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -32648,7 +32648,18 @@ Therefore, the affected-histogram name has to have at least one dot in it.

</summary>

</histogram>

+<histogram name="Settings.JsonDataReadSizeKilobytes" units="KB">

+ <owner>gab@chromium.org</owner>

+ <summary>

+ The size (in kilobytes) of the JSON settings read from disk on startup.

+ Suffixed with the name of the corresponding JSON file.

+ </summary>

+</histogram>

+ <obsolete>

+ Deprecated 02/2015. Replaced by Settings.JsonDataReadSizeKilobytes.

+ </obsolete>

<owner>gab@chromium.org</owner>

The size of the JSON settings content about to be written to disk in

@@ -62180,6 +62191,7 @@ To add a new entry, add it with any value and run test to compute valid value.

+ <affected-histogram name="Settings.JsonDataReadSizeKilobytes"/>

<affected-histogram name="Settings.JsonDataSizeKilobytes"/>

</histogram_suffixes>

« no previous file with comments | « base/prefs/json_pref_store.cc ('k') | no next file » | no next file with comments »