Log pref file size histogram on read rather than on write.

base/json/json_file_value_serializer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/json/json_file_value_serializer.h"
 
 #include "base/files/file_util.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/logging.h"
+#include "base/metrics/histogram.h"
 
 using base::FilePath;
 
 const char JSONFileValueSerializer::kAccessDenied[] = "Access denied.";
 const char JSONFileValueSerializer::kCannotReadFile[] = "Can't read file.";
 const char JSONFileValueSerializer::kFileLocked[] = "File locked.";
 const char JSONFileValueSerializer::kNoSuchFile[] = "File doesn't exist.";
 
 bool JSONFileValueSerializer::Serialize(const base::Value& root) {
   return SerializeInternal(root, false);
@@ skipping 32 matching lines @@
       return JSON_FILE_LOCKED;
     } else if (error == ERROR_ACCESS_DENIED) {
       return JSON_ACCESS_DENIED;
     }
 #endif
     if (!base::PathExists(json_file_path_))
       return JSON_NO_SUCH_FILE;
     else
       return JSON_CANNOT_READ_FILE;
   }
+
+  if (!histogram_suffix_.empty()) {
+    // The histogram below is an expansion of the UMA_HISTOGRAM_CUSTOM_COUNTS
+    // macro adapted to allow for a dynamically suffixed histogram name.
+    // Note: The factory creates and owns the histogram.
+    base::HistogramBase* histogram =
+        base::Histogram::FactoryGet(
+            "Settings.JsonDataSizeKilobytes." + histogram_suffix_,

[Alexei Svitkine (slow), 2015/01/30 13:49:03]

Should be JsonDataReadSizeKilobytes.

[gab, 2015/01/30 17:33:37]

Oops, done.

+            1,
+            10000,
+            50,
+            base::HistogramBase::kUmaTargetedHistogramFlag);
+    histogram->Add(static_cast<int>(json_string->size()) / 1024);
+  }
+
   return JSON_NO_ERROR;
 }
 
 const char* JSONFileValueSerializer::GetErrorMessageForCode(int error_code) {
   switch (error_code) {
     case JSON_NO_ERROR:
       return "";
     case JSON_ACCESS_DENIED:
       return kAccessDenied;
     case JSON_CANNOT_READ_FILE:
@@ skipping 17 matching lines @@
       *error_code = error;
     if (error_str)
       *error_str = GetErrorMessageForCode(error);
     return NULL;
   }
 
   JSONStringValueSerializer serializer(json_string);
   serializer.set_allow_trailing_comma(allow_trailing_comma_);
   return serializer.Deserialize(error_code, error_str);
 }