Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Unified Diff: test/cctest/test-cpu-profiler.cc

Issue 891663002: Make GCC happy with test-cpu-profiler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-cpu-profiler.cc
diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc
index fef3c9bac141ceef26d010f8d4d165a9fbfadcbe..7b946076fb4cf48b46e146a340f56a7911c0fedb 100644
--- a/test/cctest/test-cpu-profiler.cc
+++ b/test/cctest/test-cpu-profiler.cc
@@ -169,17 +169,17 @@ TEST(CodeEvents) {
CodeEntry* comment = generator.code_map()->FindEntry(comment_code->address());
CHECK(comment);
- CHECK_EQ("comment", comment->name());
+ CHECK_EQ(0, strcmp("comment", comment->name()));
CodeEntry* args5 = generator.code_map()->FindEntry(args5_code->address());
CHECK(args5);
- CHECK_EQ("5", args5->name());
+ CHECK_EQ(0, strcmp("5", args5->name()));
CHECK(!generator.code_map()->FindEntry(comment2_code->address()));
CodeEntry* comment2 = generator.code_map()->FindEntry(moved_code->address());
CHECK(comment2);
- CHECK_EQ("comment2", comment2->name());
+ CHECK_EQ(0, strcmp("comment2", comment2->name()));
}
@@ -230,15 +230,15 @@ TEST(TickEvents) {
const i::List<ProfileNode*>* top_down_root_children =
profile->top_down()->root()->children();
CHECK_EQ(1, top_down_root_children->length());
- CHECK_EQ("bbb", top_down_root_children->last()->entry()->name());
+ CHECK_EQ(0, strcmp("bbb", top_down_root_children->last()->entry()->name()));
const i::List<ProfileNode*>* top_down_bbb_children =
top_down_root_children->last()->children();
CHECK_EQ(1, top_down_bbb_children->length());
- CHECK_EQ("5", top_down_bbb_children->last()->entry()->name());
+ CHECK_EQ(0, strcmp("5", top_down_bbb_children->last()->entry()->name()));
const i::List<ProfileNode*>* top_down_stub_children =
top_down_bbb_children->last()->children();
CHECK_EQ(1, top_down_stub_children->length());
- CHECK_EQ("ddd", top_down_stub_children->last()->entry()->name());
+ CHECK_EQ(0, strcmp("ddd", top_down_stub_children->last()->entry()->name()));
const i::List<ProfileNode*>* top_down_ddd_children =
top_down_stub_children->last()->children();
CHECK_EQ(0, top_down_ddd_children->length());
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698