Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 891643002: Consistent capitalization and punctuation for permission requests (Closed)

Created:
5 years, 10 months ago by felt
Modified:
5 years, 10 months ago
CC:
chromium-reviews, Peter Beverloo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Consistent capitalization and punctuation for permission requests The permission request text fragments (shown in permission bubbles) should have consistent capitalization and punctuation, in the format: * Foo * Foo and bar * Foo bar Also renames "Desktop notifications" to "Notifications." BUG=451490, 453902 Committed: https://crrev.com/f85f099e5bd3d9c61f4a6cd0e3c2f35cbb3bfe1e Cr-Commit-Position: refs/heads/master@{#313986}

Patch Set 1 #

Patch Set 2 : Shorten "desktop notifications" to "notifications" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/generated_resources.grd View 4 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
felt
Mounir, PTAL. Cleaning up some permission strings.
5 years, 10 months ago (2015-01-30 05:09:33 UTC) #2
felt
On 2015/01/30 05:09:33, felt wrote: > Mounir, PTAL. Cleaning up some permission strings. or groby, ...
5 years, 10 months ago (2015-01-30 18:00:11 UTC) #4
mlamouri (slow - plz ping)
lgtm but please update the description to mention the "Desktop Notifications" -> "Notifications" change. A ...
5 years, 10 months ago (2015-01-30 19:30:52 UTC) #5
mlamouri (slow - plz ping)
+CC peter@ so he is aware of the notification permission text change.
5 years, 10 months ago (2015-01-30 19:31:34 UTC) #6
felt
On 2015/01/30 19:30:52, Mounir Lamouri wrote: > lgtm but please update the description to mention ...
5 years, 10 months ago (2015-01-30 19:34:56 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891643002/20001
5 years, 10 months ago (2015-01-30 19:35:36 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-01-30 20:46:32 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-01-30 20:47:41 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f85f099e5bd3d9c61f4a6cd0e3c2f35cbb3bfe1e
Cr-Commit-Position: refs/heads/master@{#313986}

Powered by Google App Engine
This is Rietveld 408576698