Revert of Reland #3: Ensure WebView notifies desktop automation on creation,

Revert of Reland #3: Ensure WebView notifies desktop automation on creation,  (patchset #2 id:20001 of https://codereview.chromium.org/907973004/)

Reason for revert:
Still flakes...

Original issue's description:
> Reland #3: Ensure WebView notifies desktop automation on creation, destruction, and change
>
> Original issue: https://codereview.chromium.org/880063002
> Previous reland attempt: https://codereview.chromium.org/895623003/
> previous reland attempt 2: https://codereview.chromium.org/890013006/
> - able to reproduce the flakes locally by running multiple copies of the same test in parallel.
> - tracked the issues down to the following points/solutions:
> 1. in automation_node.js, we now fire a loadComplete event if we detect a loaded root within enableFrame's callback. Previously, there could be a situation where a tree was already finished loading so it never actually fires that load complete.
> 2. in automation_node.js, we now store the callback that fires childrenChanged and the loadComplete above before requesting the browser initiate tree only accessibility which sends down the data.
> 3. in chromevox_next_e2e_test_base.js, we now check that the url contains 'test' to avoid processing loadCompletes from other rootWebAreas (e.g. about:blank).
>
> TBR=dmazzoni@chromium.org
>
> Committed: https://crrev.com/4da650e88c859e6d1c2d82993cd6ed3376e77f80
> Cr-Commit-Position: refs/heads/master@{#315785}

TBR=dmazzoni@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Committed: https://crrev.com/0672f1e23fe1825ecc849a6ac66bab4ffbf43fbf
Cr-Commit-Position: refs/heads/master@{#315794}

[David Tseng, 2015-02-11 18:05:34]

Created Revert of Reland #3: Ensure WebView notifies desktop automation on
creation,

[commit-bot: I haz the power, 2015-02-11 18:06:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/891633004/1

[commit-bot: I haz the power, 2015-02-11 18:07:47]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-11 18:08:33]

Patchset 1 (id:??) landed as
https://crrev.com/0672f1e23fe1825ecc849a6ac66bab4ffbf43fbf
Cr-Commit-Position: refs/heads/master@{#315794}

[David Tseng, 2015-02-11 18:17:11]

I believe a different issue is at the root of flakes here
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%2...

It looks like an alert is being processed and possibly trumps speech.


On Wed, Feb 11, 2015 at 10:05 AM, <dtseng@chromium.org> wrote:

> Reviewers: dmazzoni,
>
> Message:
> Created Revert of Reland #3: Ensure WebView notifies desktop automation on
> creation,
>
> Description:
> Revert of Reland #3: Ensure WebView notifies desktop automation on
> creation,
> (patchset #2 id:20001 of https://codereview.chromium.org/907973004/)
>
> Reason for revert:
> Still flakes...
>
> Original issue's description:
>
>> Reland #3: Ensure WebView notifies desktop automation on creation,
>>
> destruction, and change
>
>  Original issue: https://codereview.chromium.org/880063002
>> Previous reland attempt: https://codereview.chromium.org/895623003/
>> previous reland attempt 2: https://codereview.chromium.org/890013006/
>> - able to reproduce the flakes locally by running multiple copies of the
>> same
>>
> test in parallel.
>
>> - tracked the issues down to the following points/solutions:
>> 1. in automation_node.js, we now fire a loadComplete event if we detect a
>>
> loaded root within enableFrame's callback. Previously, there could be a
> situation where a tree was already finished loading so it never actually
> fires
> that load complete.
>
>> 2. in automation_node.js, we now store the callback that fires
>> childrenChanged
>>
> and the loadComplete above before requesting the browser initiate tree only
> accessibility which sends down the data.
>
>> 3. in chromevox_next_e2e_test_base.js, we now check that the url contains
>>
> 'test' to avoid processing loadCompletes from other rootWebAreas (e.g.
> about:blank).
>
>  TBR=dmazzoni@chromium.org
>>
>
>  Committed: https://crrev.com/4da650e88c859e6d1c2d82993cd6ed3376e77f80
>> Cr-Commit-Position: refs/heads/master@{#315785}
>>
>
> TBR=dmazzoni@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
>
> Please review this at https://codereview.chromium.org/891633004/
>
> Base URL: https://chromium.googlesource.com/chromium/src.git@master
>
> Affected files (+129, -165 lines):
>   M chrome/browser/resources/chromeos/chromevox/common/
> chrome_extension_externs.js
>   M chrome/browser/resources/chromeos/chromevox/common/
> editable_text_base.js
>   M chrome/browser/resources/chromeos/chromevox/cvox2/
> background/automation_util.js
>   M chrome/browser/resources/chromeos/chromevox/cvox2/
> background/automation_util_test.extjs
>   M chrome/browser/resources/chromeos/chromevox/cvox2/
> background/background.js
>   M chrome/browser/resources/chromeos/chromevox/cvox2/
> background/background_test.extjs
>   M chrome/browser/resources/chromeos/chromevox/cvox2/
> background/cursors_test.extjs
>   M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
>   M chrome/browser/resources/chromeos/chromevox/cvox2/
> background/output_test.extjs
>   M chrome/browser/resources/chromeos/chromevox/testing/
> chromevox_e2e_test_base.js
>   M chrome/browser/resources/chromeos/chromevox/testing/
> chromevox_next_e2e_test_base.js
>   M chrome/browser/resources/chromeos/chromevox/testing/mock_tts.js
>   M chrome/renderer/resources/extensions/automation/automation_node.js
>   M chrome/test/base/extension_js_browser_test.h
>   M chrome/test/base/extension_load_waiter_one_shot.h
>   M ui/views/accessibility/ax_aura_obj_cache.h
>   M ui/views/accessibility/ax_aura_obj_cache.cc
>   M ui/views/accessibility/ax_widget_obj_wrapper.cc
>   M ui/views/controls/webview/webview.h
>   M ui/views/controls/webview/webview.cc
>
>
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.