Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp - Issue 891633003: make window interceptors AllCanRead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp

Issue 891633003: make window interceptors AllCanRead (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: test from issue Created 5 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestSpecialOperations.cpp ('k') | Source/bindings/tests/results/modules/V8TestInterface5.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp

diff --git a/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp b/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp

index 5498c3e62ea1d9be7b5c5f5367fc59a94a755db6..54962c8d2368d7ebbe029c9775ad59dfb45c2aee 100644

--- a/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp

+++ b/Source/bindings/tests/results/core/V8TestSpecialOperationsNotEnumerable.cpp

@@ -85,8 +85,14 @@ static void installV8TestSpecialOperationsNotEnumerableTemplate(v8::Local<v8::Fu

ALLOW_UNUSED_LOCAL(instanceTemplate);

v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

ALLOW_UNUSED_LOCAL(prototypeTemplate);

- functionTemplate->InstanceTemplate()->SetHandler(v8::IndexedPropertyHandlerConfiguration(TestSpecialOperationsNotEnumerableV8Internal::indexedPropertyGetterCallback, 0, 0, 0, 0));

- functionTemplate->InstanceTemplate()->SetHandler(v8::NamedPropertyHandlerConfiguration(TestSpecialOperationsNotEnumerableV8Internal::namedPropertyGetterCallback, 0, 0, 0, 0));

+ {

+ v8::IndexedPropertyHandlerConfiguration config(TestSpecialOperationsNotEnumerableV8Internal::indexedPropertyGetterCallback, 0, 0, 0, 0);

+ functionTemplate->InstanceTemplate()->SetHandler(config);

+ }

+ {

+ v8::NamedPropertyHandlerConfiguration config(TestSpecialOperationsNotEnumerableV8Internal::namedPropertyGetterCallback, 0, 0, 0, 0);

+ functionTemplate->InstanceTemplate()->SetHandler(config);

+ }

// Custom toString template

functionTemplate->Set(v8AtomicString(isolate, "toString"), V8PerIsolateData::from(isolate)->toStringTemplate());