sky/engine/core/rendering/RootInlineBox.cpp - Issue 891573002: Removed a bunch of unneeded paint phase checks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/rendering/RootInlineBox.cpp

Issue 891573002: Removed a bunch of unneeded paint phase checks. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/rendering/RootInlineBox.cpp

diff --git a/sky/engine/core/rendering/RootInlineBox.cpp b/sky/engine/core/rendering/RootInlineBox.cpp

index 57a2cbdf92820a47c49039a4b75472a120a963df..c56887d912a5dec865405bc322e57c011e6a0e42 100644

--- a/sky/engine/core/rendering/RootInlineBox.cpp

+++ b/sky/engine/core/rendering/RootInlineBox.cpp

@@ -151,7 +151,7 @@ float RootInlineBox::placeEllipsisBox(bool ltr, float blockLeftEdge, float block

void RootInlineBox::paintEllipsisBox(PaintInfo& paintInfo, const LayoutPoint& paintOffset, LayoutUnit lineTop, LayoutUnit lineBottom) const

{

- if (hasEllipsisBox() && paintInfo.phase == PaintPhaseForeground)

+ if (hasEllipsisBox())

ellipsisBox()->paint(paintInfo, paintOffset, lineTop, lineBottom);

}