Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: sky/engine/core/rendering/RenderLayer.cpp

Issue 891573002: Removed a bunch of unneeded paint phase checks. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/rendering/RenderLayer.cpp
diff --git a/sky/engine/core/rendering/RenderLayer.cpp b/sky/engine/core/rendering/RenderLayer.cpp
index f2192036762b5bf285781a75e37b35138fefa13f..47495eca070f9aad7ed801871ebb6cbe95ce5b46 100644
--- a/sky/engine/core/rendering/RenderLayer.cpp
+++ b/sky/engine/core/rendering/RenderLayer.cpp
@@ -1016,10 +1016,9 @@ void RenderLayer::paintForeground(GraphicsContext* context, GraphicsContext* tra
if (shouldClip)
clipToRect(localPaintingInfo, context, layerForegroundRect);
+ // TODO(ojan): We probably should early return at the beginning of this function
+ // if the rect is empty.
if (!foregroundRectIsEmpty) {
- // We have to loop through every fragment multiple times, since we have to issue paint invalidations in each specific phase in order for
- // interleaving of the fragments to work properly.
- // FIXME(sky): Do we still need this for anything now that we don't have fragments?
paintForegroundWithPhase(PaintPhaseForeground,
context, localPaintingInfo,
layerLocation, layerForegroundRect);

Powered by Google App Engine
This is Rietveld 408576698