Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 891563004: Make the Material Design PDF Viewer's toolbar thinner (Closed)

Created:
5 years, 10 months ago by Alexandre Carlton
Modified:
5 years, 10 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the Material Design PDF Viewer's toolbar thinner The main toolbar of the Material Design PDF Viewer (at the top containing page selection functionality) is set to use the 'core-narrow' class, setting it to the same height as the toolbar in Inbox by Google. BUG=110020 Committed: https://crrev.com/7e8cd61f389cc099f1d7bf40507094cdc770e5a8 Cr-Commit-Position: refs/heads/master@{#314293}

Patch Set 1 #

Patch Set 2 : Add padding to the toolbar #

Patch Set 3 : Rebase before commit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M chrome/browser/resources/pdf/index-material.css View 1 2 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/pdf/index-material.html View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (2 generated)
Alexandre Carlton
5 years, 10 months ago (2015-01-30 07:09:36 UTC) #2
raymes
lgtm
5 years, 10 months ago (2015-02-02 00:34:34 UTC) #3
Sam McNally
Make which toolbar thinner?
5 years, 10 months ago (2015-02-02 05:58:12 UTC) #4
Alexandre Carlton
Specified which toolbar was made narrower.
5 years, 10 months ago (2015-02-02 06:03:09 UTC) #5
Sam McNally
On 2015/02/02 06:03:09, Alexandre Carlton wrote: > Specified which toolbar was made narrower. PDF viewer ...
5 years, 10 months ago (2015-02-02 06:07:13 UTC) #6
benwells
On 2015/02/02 06:07:13, Sam McNally wrote: > On 2015/02/02 06:03:09, Alexandre Carlton wrote: > > ...
5 years, 10 months ago (2015-02-02 09:57:50 UTC) #7
benwells
On 2015/02/02 09:57:50, benwells wrote: > On 2015/02/02 06:07:13, Sam McNally wrote: > > On ...
5 years, 10 months ago (2015-02-02 09:58:03 UTC) #8
Sam McNally
lgtm
5 years, 10 months ago (2015-02-03 07:23:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891563004/40001
5 years, 10 months ago (2015-02-03 07:44:55 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 10 months ago (2015-02-03 08:36:57 UTC) #12
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 08:38:49 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7e8cd61f389cc099f1d7bf40507094cdc770e5a8
Cr-Commit-Position: refs/heads/master@{#314293}

Powered by Google App Engine
This is Rietveld 408576698