Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
891543002:
my_activity.py: Add brillo bug tracker. (Closed)
|
Created:
5 years, 10 months ago by deymo Modified:
5 years, 10 months ago CC:
chromium-reviews, cmp-cc_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master Target Ref:
refs/heads/master Project:
tools Visibility:
Public. |
Descriptionmy_activity.py: Add brillo bug tracker.
BUG=brillo:90
TEST=./my_activity.py shows brillo bugs.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=293912
Patch Set 1 #
Messages
Total messages: 22 (9 generated)
deymo@chromium.org changed reviewers: + cmp@chromium.org, maruel@chromium.org
lgtm
The CQ bit was checked by deymo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 891543002-1 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Pylint (113 files) (126.11s) failed ************* Module gclient_test W:997, 6: Redundant use of assertFalse with constant value 'unreachable code' (redundant-unittest-assert) W:1022, 6: Redundant use of assertFalse with constant value 'unreachable code' (redundant-unittest-assert) Presubmit checks took 188.9s to calculate.
:( The failure is completely unrelated. Can any of you chump this change?
The CQ bit was checked by deymo@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 891543002-1 failed and returned exit status 1. Running presubmit commit checks ... Checking out rietveld... Running save-description-on-failure.sh Running push-basic.sh Running upstream.sh Running submit-from-new-dir.sh Running abandon.sh Running submodule-merge-test.sh Running upload-local-tracking-branch.sh Running hooks.sh Running post-dcommit-hook-test.sh Running upload-stale.sh Running patch.sh Running basic.sh ** Presubmit ERRORS ** Pylint (113 files) (127.71s) failed ************* Module gclient_test W:997, 6: Redundant use of assertFalse with constant value 'unreachable code' (redundant-unittest-assert) W:1022, 6: Redundant use of assertFalse with constant value 'unreachable code' (redundant-unittest-assert) Presubmit checks took 165.5s to calculate.
Landed https://codereview.chromium.org/884243006/ which should fix the failing presubmit. I don't know why it broke in the first place (haven't made a depot_tools change in a long time). FYI for the future, it would have been fine for you to modify your CL to fix the problem directly. Then no chumping would be necessary (chumping is bad) and your CL would have been able to land some time ago.
The CQ bit was checked by cmp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891543002/1
The CQ bit was unchecked by commit-bot@chromium.org
Presubmit check for 891543002-1 failed and returned exit status 1.
Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh
** Presubmit ERRORS **
tests/checkout_test.py (37.78s) failed
Cloning into '/tmp/trialpz0c0l/__main__.GitCheckout.testAll/foo'...
done.
Switched to branch 'master'
Already on 'master'
.ECloning into '/tmp/trialpz0c0l/__main__.GitCheckout.testMove/foo'...
done.
.Cloning into '/tmp/trialpz0c0l/__main__.GitCheckout.testProcess/foo'...
done.
....................
======================================================================
ERROR: testException (__main__.GitCheckout)
----------------------------------------------------------------------
Traceback (most recent call last):
File "tests/checkout_test.py", line 347, in setUp
self.enabled = self.FAKE_REPOS.set_up_git()
File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 359, in set_up_git
self.set_up()
File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 211, in set_up
self.cleanup_dirt()
File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 229, in cleanup_dirt
if not self.tear_down_git():
File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 276, in tear_down_git
wait_for_port_to_free(self.host, self.git_port)
File
"/b/infra_internal/commit_queue/workdir/tools/depot_tools/testing_support/fake_repos.py",
line 161, in wait_for_port_to_free
assert False, '%d is still bound' % port
AssertionError: 20000 is still bound
----------------------------------------------------------------------
Ran 23 tests in 37.567s
FAILED (errors=1)
Presubmit checks took 161.9s to calculate.
The CQ bit was checked by cmp@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891543002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1) as http://src.chromium.org/viewvc/chrome?view=rev&revision=293912
Message was sent while issue was closed.
remixz2000@gmail.com changed reviewers: + Remixz2000@gmail.com
Message was sent while issue was closed.
lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
