Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Issue 891503002: Removes nameservice syscall definition (Closed)

Created:
5 years, 10 months ago by Petr Hosek
Modified:
5 years, 10 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
ssh://gerrit.chromium.org/native_client/nacl-glibc.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Removes nameservice syscall definition Prerequisite to the removal of nameservice system call from service runtime as a part of SRPC removal. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3864 TEST=trybots R=mcgrathr@chromium.org Committed: https://git.chromium.org/gitweb?p=native_client/nacl-glibc.git;a=commit;h=4e5aab57fe4cba7ae8e7f09d63b8c07f191cd6db

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M sysdeps/nacl/nacl_syscalls.h View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Petr Hosek
5 years, 10 months ago (2015-01-29 20:43:40 UTC) #2
Mark Seaborn
LGTM. Technically you should run toolchain trybots before committing this.
5 years, 10 months ago (2015-01-29 21:17:25 UTC) #3
Petr Hosek
On 2015/01/29 21:17:25, Mark Seaborn wrote: > LGTM. Technically you should run toolchain trybots before ...
5 years, 10 months ago (2015-01-29 22:17:07 UTC) #4
Roland McGrath
lgtm
5 years, 10 months ago (2015-01-30 00:54:17 UTC) #5
commit-bot: I haz the power
Commit queue rejected this change because it did not recognize the base URL. Please commit ...
5 years, 10 months ago (2015-01-30 04:09:19 UTC) #8
Petr Hosek
5 years, 10 months ago (2015-01-30 16:01:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4e5aab57fe4cba7ae8e7f09d63b8c07f191cd6db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698