Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Unified Diff: components/enhanced_bookmarks/enhanced_bookmark_utils.h

Issue 891493003: [Android] Upstreamed Stars UMA from iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed GN nits and fixed gyp Created 5 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/enhanced_bookmarks/enhanced_bookmark_utils.h
diff --git a/components/enhanced_bookmarks/enhanced_bookmark_utils.h b/components/enhanced_bookmarks/enhanced_bookmark_utils.h
index dc9cf3c85665fda96c7a4b5fef3b465e04ce0b46..1ab8b12c1e8f94d2e2bec2f9a9ac9e5fcaa18d7e 100644
--- a/components/enhanced_bookmarks/enhanced_bookmark_utils.h
+++ b/components/enhanced_bookmarks/enhanced_bookmark_utils.h
@@ -17,6 +17,23 @@ class BookmarkModel;
namespace enhanced_bookmarks {
+static const char kLaunchLocationUMA[] = "Stars.LaunchLocation";
+
+// Possible locations where a bookmark can be opened from.
+// Please sync with the corresponding histograms.xml.
+//
+// A Java counterpart will be generated for this enum.
+// GENERATED_JAVA_ENUM_PACKAGE: org.chromium.chrome.browser.enhancedbookmark
+enum LaunchLocation {
+ ALL_ITEMS = 0,
+ UNCATEGORIZED = 1, // Deprecated.
+ FOLDER = 2,
+ FILTER = 3,
+ SEARCH = 4,
+ BOOKMARK_EDITOR = 5,
+ COUNT = 6,
+};
+
// The vector is sorted in place.
// All of the bookmarks in |nodes| must be urls.
void SortBookmarksByName(std::vector<const BookmarkNode*>& nodes);
« components/enhanced_bookmarks/BUILD.gn ('K') | « components/enhanced_bookmarks/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698