Issue 891473004: StartPageService: Use a StringPiece instead of modifying a string.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 891473004: StartPageService: Use a StringPiece instead of modifying a string. (Closed)

Created:
5 years, 10 months ago by Matt Giuca

Modified:
5 years, 10 months ago

Reviewers:
calamity

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina

Base URL:
https://chromium.googlesource.com/chromium/src.git@jsonstring-stringpiece

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

StartPageService: Use a StringPiece instead of modifying a string. This is possible now that JSONStringValueSerializer takes a StringPiece. BUG=455068 Committed: https://crrev.com/bf7077883810ce30907c2d8e68bd50c1a5853af1 Cr-Commit-Position: refs/heads/master@{#314770}

Patch Set 1 #

Created: 5 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	chrome/browser/ui/app_list/start_page_service.cc	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891473004/1

5 years, 10 months ago (2015-02-05 06:13:34 UTC) #5

commit-bot: I haz the power

5 years, 10 months ago (2015-02-05 06:59:33 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bf7077883810ce30907c2d8e68bd50c1a5853af1
Cr-Commit-Position: refs/heads/master@{#314770}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages