Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 891353005: Add build targets for Opus tests. (Closed)

Created:
5 years, 10 months ago by wtc
Modified:
5 years, 10 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Relanding of Add build targets for Opus tests. (patchset #2 id:20001 of https://codereview.chromium.org/894473002/) test_opus_api, test_opus_encode, test_opus_decode, and test_opus_padding can be run directly, with no command-line options, and they print out "OK" during the test and an overall status message such as "All API tests passed." or "Tests completed successfully." at the end. The celt component has several unit tests. I didn't add build targets for them because some of them don't print any output, so you'd need a test harness script to examine their exit status. R=henrika@chromium.org,sergeyu@chromium.org BUG=452984 Committed: https://crrev.com/626f929de03b5a32a58c9148970684b890cdca81 Cr-Commit-Position: refs/heads/master@{#314379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -66 lines) Patch
M third_party/opus/BUILD.gn View 4 chunks +93 lines, -27 lines 0 comments Download
M third_party/opus/opus.gyp View 3 chunks +78 lines, -39 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
wtc
A good way to review this relanding CL is to compare it with the original ...
5 years, 10 months ago (2015-02-03 17:47:08 UTC) #1
Sergey Ulanov
lgtm
5 years, 10 months ago (2015-02-03 17:50:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891353005/1
5 years, 10 months ago (2015-02-03 17:58:39 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 19:17:20 UTC) #5
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 19:18:44 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/626f929de03b5a32a58c9148970684b890cdca81
Cr-Commit-Position: refs/heads/master@{#314379}

Powered by Google App Engine
This is Rietveld 408576698