Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 891353004: Make --disable-mojo-channel work on the browser process (Closed)

Created:
5 years, 10 months ago by Hajime Morrita
Modified:
5 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make --disable-mojo-channel work on the browser process This is a embarassing followup of http://crrev.com/886153003 which introduced --disable-mojo-channel flag. The change didn't work as RenderProcessHostImpl refers the function that should've removed. This CL removes the useless function whose name masked the one of the newly added. R=nasko@chromium.org BUG=377980 Committed: https://crrev.com/03871907f022dc7e85844a69f9122158727fccf3 Cr-Commit-Position: refs/heads/master@{#314225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -8 lines) Patch
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Hajime Morrita
5 years, 10 months ago (2015-02-02 22:03:19 UTC) #1
Hajime Morrita
Nasko, Could you please take a look at this facepalm change of mine... :/
5 years, 10 months ago (2015-02-02 22:05:03 UTC) #2
nasko
LGTM
5 years, 10 months ago (2015-02-02 22:10:41 UTC) #3
Hajime Morrita
On 2015/02/02 22:10:41, nasko wrote: > LGTM Thank you!
5 years, 10 months ago (2015-02-02 22:12:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891353004/1
5 years, 10 months ago (2015-02-02 22:13:19 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 10 months ago (2015-02-03 00:34:35 UTC) #7
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 00:35:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/03871907f022dc7e85844a69f9122158727fccf3
Cr-Commit-Position: refs/heads/master@{#314225}

Powered by Google App Engine
This is Rietveld 408576698