Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 891323002: Add missing policies to to device policy proto (Closed)

Created:
5 years, 10 months ago by bartfab (slow)
Modified:
5 years, 10 months ago
CC:
chromium-reviews, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, oshima+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@g_1_430908_add_heartbeat_settings_device_policy
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add missing policies to to device policy proto The |report_session_status| and |device_status_frequency| policies were added on the server side in violation of our protocol: Policies must always be added to the client-side proto first and synced to the server. In general, new policies should be added to the device policy proto and policy_templates.json at the same time. As an emergency fix, this CL gets a free pass for that rule as it is an emergency fix. BUG=430908 TEST=None Committed: https://crrev.com/24f3c46512a7dcf3607855a5efaf6a7a1595e0f6 Cr-Commit-Position: refs/heads/master@{#314347}

Patch Set 1 #

Patch Set 2 : Added one more missing policy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/browser/chromeos/policy/proto/chrome_device_policy.proto View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
bartfab (slow)
Hi Drew, Please take a look.
5 years, 10 months ago (2015-02-02 12:31:55 UTC) #2
Andrew T Wilson (Slow)
lgtm
5 years, 10 months ago (2015-02-03 15:45:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/891323002/20001
5 years, 10 months ago (2015-02-03 15:53:01 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 10 months ago (2015-02-03 16:29:03 UTC) #6
commit-bot: I haz the power
5 years, 10 months ago (2015-02-03 16:31:02 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/24f3c46512a7dcf3607855a5efaf6a7a1595e0f6
Cr-Commit-Position: refs/heads/master@{#314347}

Powered by Google App Engine
This is Rietveld 408576698